Add support for variables in text style.#371
Add support for variables in text style.#371GiniAppsPartners wants to merge 6 commits intomasterfrom
Conversation
adimiz1
left a comment
adimiz1
left a comment
There was a problem hiding this comment.
You added the ability to add text style via String, but what about adding it via expression?
You can see the implementation in the Java PR
Also I've added a new expression myself to the iOS SDK, you can see it in the branch:
feature/angle_expression
adimiz1
left a comment
adimiz1
left a comment
There was a problem hiding this comment.
Hi Alex
Please break this PR into two separate PR's
One for text style
And the other for expression normalization
Also please fix an comment I remarked on the expression normalization
| guard !currentKey.isEmpty && !currentValue.isEmpty else { | ||
|
|
||
| guard !currentKey.isEmpty else { | ||
| if allSpaceAndOrDash { |
There was a problem hiding this comment.
A specific use case of regex expression should not impact the asString() function
This should be handled in the Regex expression and not outside of it
There was a problem hiding this comment.
I understood that this is the new requirements (according to Patriks tests)
Meaning if the value contains "allSpaceAndOrDash" then asString() should return "_" otherwise the tests fail.
4 participants
Brief Summary of Changes
Add support for variables in text style.
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: